Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making @best/cli leaner #187

Closed
pmdartus opened this issue Jul 29, 2019 · 1 comment
Closed

Making @best/cli leaner #187

pmdartus opened this issue Jul 29, 2019 · 1 comment
Assignees

Comments

@pmdartus
Copy link
Member

Observations

When installing for the first time @best/cli I noticed that it takes around 20 sec. I also realized @best/cli pull-down 151 MB worth of NPM dependencies.

When looking at the generated yarn.lock you can observe that @best/cli it possible to see that some projects like webpack or jest are also pulled down. When running npm ls --json that out of the 3159 dependencies listed, 2508 are pulled down by the @best/frontend.

Is it possible to make the @best/cli dependency on @best/frontend optional?

Reproduction steps

mkdir test
cd test
yarn init -y
yarn add -D @best/cli

Versions

  • node: 10.16.0
  • best: 4.0.0-alpha4
@jasonsilberman
Copy link
Contributor

I think what we can do is remove the dependency on the frontend, as it is only used when a user tries to generate the static HTML frontend. So we can require that a user list that as a peer dependency when they want to use that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants