Combobox: ARIA attribute fixes #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read-only combobox had two copies of ARIA attributes
Added due to autocomplete bug in browsers. Invalid value of "test" is passed into `autoComplete` intentionally.
- Remove duplicate attributes - align node IDs
ID was invalid since it was not rendered on the screen at the time
section tag should only be used for Popover. See SLDS markup
interactivellama
force-pushed
the
aria-attributes-fix
branch
from
0523521
to
f297a18
Compare
kevinparkerson
suggested changes
Jun 13, 2019
|
@kevinparkerson Do the combobox a11y tests pass? |
|
You will need to do an |
…to aria-attributes-fix # Conflicts: # components/tooltip/__docs__/__snapshots__/storybook-stories.storyshot # package-lock.json # package.json
interactivellama
temporarily deployed
to
design-system-react-co-pr-2004
|
@kevinparkerson Updated |
| autoComplete="test" | ||
| id="id_from_input_prop" |
There was a problem hiding this comment.
@interactivellama why was this id removed? not needed for snapshot testing?
There was a problem hiding this comment.
Yes, it was not needed.
|
@interactivellama still seeing this locally: |
|
|
When evaluating '.slds-combobox[aria-haspopup="dialog"' selector
interactivellama
temporarily deployed
to
design-system-react-co-pr-2004
kevinparkerson
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2003
Additional description
This allows aXe audit to pass for Combobox.
npm run test:a11y@jcjuett @kevinparkerson
@aswinshenoy @pulkonet When you run
npm run test:a11yon your new work (and you should! -- but it is not currently in the TravisCI tasks list for all pull requests today). This PR may help with fixing some of the errors.The issues were duplicate ARIA attributes used when only one was set was needed and that HTML IDs were being referenced when they were not on the page, since it's React convention to only add visible HTML nodes to the page such as when displaying menus, popovers, and tooltips.
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.