Skip to content

Commit

Permalink
feat: remove dependency upgrades to see whether that fixes build issu…
Browse files Browse the repository at this point in the history
…es @W-14387292
  • Loading branch information
seckardt committed Oct 31, 2023
1 parent 1418f0f commit 522c87c
Show file tree
Hide file tree
Showing 3 changed files with 180 additions and 349 deletions.
11 changes: 4 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,15 @@
"release:publish": "npm publish --registry=https://registry.npmjs.org"
},
"devDependencies": {
"@babel/core": "^7.22.20",
"@babel/eslint-parser": "^7.22.15",
"@typescript-eslint/parser": "^6.9.1",
"@typescript-eslint/rule-tester": "^6.9.1",
"eslint": "^8.52.0",
"@babel/core": "^7.22.5",
"@babel/eslint-parser": "^7.22.5",
"eslint": "^8.44.0",
"husky": "^8.0.3",
"lint-staged": "^13.2.3",
"mocha": "^10.2.0",
"nyc": "^15.1.0",
"prettier": "^2.8.8",
"semver": "^7.5.3",
"typescript": "^5.2.2"
"semver": "^7.5.3"
},
"dependencies": {
"globals": "^13.20.0",
Expand Down
18 changes: 2 additions & 16 deletions test/lib/rules/no-restricted-browser-globals-during-ssr.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,12 @@
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
'use strict';
const mocha = require('mocha');
const { RuleTester } = require('@typescript-eslint/rule-tester');
RuleTester.afterAll = mocha.after;
const { RuleTester } = require('eslint');

const { ESLINT_TEST_CONFIG } = require('../shared');
const rule = require('../../../lib/rules/no-restricted-browser-globals-during-ssr');

const tester = new RuleTester({
...ESLINT_TEST_CONFIG,
parser: '@typescript-eslint/parser',
});
const tester = new RuleTester(ESLINT_TEST_CONFIG);

tester.run('no-browser-globals-during-ssr', rule, {
valid: [
Expand Down Expand Up @@ -268,15 +263,6 @@ tester.run('no-browser-globals-during-ssr', rule, {
}
`,
},
{
code: `
import { LightningElement } from 'lwc';
export default class Foo extends LightningElement {
private property: MyType = null;
}
`,
},
],
invalid: [
{
Expand Down
Loading

0 comments on commit 522c87c

Please sign in to comment.