feat(engine): Add support for isConnected on LightningElement #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravijayaramappa
commented
Feb 7, 2020
| get isConnected(): boolean { | ||
| const vm = getAssociatedVM(this); | ||
| const { elm } = vm; | ||
| return elm.isConnected; |
There was a problem hiding this comment.
isConnected is polyfiled in @lwc/synthetic-shadow https://github.com/salesforce/lwc/blob/master/packages/@lwc/synthetic-shadow/src/faux-shadow/node.ts#L470
caridy
approved these changes
Feb 7, 2020
pmdartus
requested changes
Feb 10, 2020
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -12,3 +12,5 @@ If yes, please describe the impact and migration path for existing applications. | |||
| ## The PR fulfills these requirements: | |||
| * Have tests for the proposed changes been added? ✅ / ❌ | |||
| * Have you followed [these instructions](../CONTRIBUTING.md#-commit-message-conventions) to clearly describe the issue being fixed or feature enhanced? ✅ / ❌ | |||
|
|
|||
| ## GUS Work Item | |||
There was a problem hiding this comment.
Let's split that in another PR.
| const componentTag = getComponentTag(vm); | ||
| assert.isFalse( | ||
| isBeingConstructed(vm), | ||
| `this.isConnected cannot be accessed during the construction phase of the custom` + |
There was a problem hiding this comment.
Suggested change
| `this.isConnected cannot be accessed during the construction phase of the custom` + | |
| `this.isConnected shouldn't be accessed during the construction phase of the custom` + |
| assert.isFalse( | ||
| isBeingConstructed(vm), | ||
| `this.isConnected cannot be accessed during the construction phase of the custom` + | ||
| ` element for ${componentTag} because it is redundant. The value will always be` + |
There was a problem hiding this comment.
Even if the error makes sense in 99% of the case, I would like to bring more nuance to this statement. If the element is already connected to the DOM before the upgrade the isConnected will be true in the constructor: https://jsfiddle.net/pmdartus/fb1Lt8wa/2/
| @@ -12,9 +12,3 @@ export interface Context { | |||
| tplCache?: Template; | |||
| [key: string]: any; | |||
| } | |||
|
|
|||
| export let currentContext: Context = {}; | |||
There was a problem hiding this comment.
Let's move the context removal to another PR.
ravijayaramappa
force-pushed
the
ravi/master/isConnected
branch
from
5654752
to
2369ea7
Compare
pmdartus
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Developers can now check if an LWC element is connected to the DOM using the
isConnectedproperty on the component instance.Fixes #1698
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements:
GUS Work Item
W-7199523