-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lwc-engine): Add Safari polyfill for Proxy #197
Conversation
It's not clear to my why we want this in lwc and not es5-proxy-compat? |
Because we don't ship compat on Safari 10. |
Benchmark comparisonBase commit:
|
} | ||
|
||
const proxy = new Proxy([3, 4], {}); | ||
const res = [1, 2].concat(proxy); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably can simplify this by concating into an empty array.
@pmdartus merging this fix is shipped, lets do backport |
Details
Add temporary mitigation to get around Safari
Array.prototype.concat
bug: https://bugs.webkit.org/show_bug.cgi?id=184267Does this PR introduce a breaking change?