chore: switch from circle ci to github actions #3783
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Run WebDriverIO integration tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - release | ||
| - 'spring*' | ||
| - 'summer*' | ||
| - 'winter*' | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| - release | ||
| - 'spring*' | ||
| - 'summer*' | ||
| - 'winter*' | ||
|
|
||
| env: | ||
| SAUCE_USERNAME: ${{secrets.SAUCE_USERNAME}} | ||
| SAUCE_ACCESS_KEY: ${{secrets.SAUCE_ACCESS_KEY}} | ||
| SAUCE_TUNNEL_ID: github-action-tunnel-karma-${{github.run_id}} | ||
| PUPPETEER_SKIP_DOWNLOAD: "true" # only needed for @best/runner-local, unused here | ||
|
|
||
| jobs: | ||
| run-integration-tests: | ||
| runs-on: ubuntu-22.04 | ||
| defaults: | ||
| run: | ||
| working-directory: ./packages/@lwc/integration-tests | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "18.18.0" | ||
| cache: 'yarn' | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| working-directory: ./ | ||
|
|
||
| - uses: saucelabs/sauce-connect-action@v2 | ||
| with: | ||
| username: ${{ secrets.SAUCE_USERNAME }} | ||
| accessKey: ${{ secrets.SAUCE_ACCESS_KEY }} | ||
| tunnelName: ${{ env.SAUCE_TUNNEL_ID }} | ||
|
|
||
| - run: yarn sauce:prod --browsers chrome | ||
| - run: yarn sauce:dev --browsers chrome |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| name: Run Karma integration tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - release | ||
| - 'spring*' | ||
| - 'summer*' | ||
| - 'winter*' | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| - release | ||
| - 'spring*' | ||
| - 'summer*' | ||
| - 'winter*' | ||
|
|
||
| env: | ||
| SAUCE_USERNAME: ${{secrets.SAUCE_USERNAME}} | ||
| SAUCE_ACCESS_KEY: ${{secrets.SAUCE_ACCESS_KEY}} | ||
| SAUCE_TUNNEL_ID: github-action-tunnel-integration-${{github.run_id}} | ||
| PUPPETEER_SKIP_DOWNLOAD: "true" # only needed for @best/runner-local, unused here | ||
| COVERAGE: "1" | ||
|
|
||
| jobs: | ||
| run-karma-tests: | ||
| runs-on: ubuntu-22.04 | ||
| defaults: | ||
| run: | ||
| working-directory: ./packages/@lwc/integration-karma | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "18.18.0" | ||
| cache: 'yarn' | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| working-directory: ./ | ||
|
|
||
| - uses: saucelabs/sauce-connect-action@v2 | ||
| with: | ||
| username: ${{ secrets.SAUCE_USERNAME }} | ||
| accessKey: ${{ secrets.SAUCE_ACCESS_KEY }} | ||
| tunnelName: ${{ env.SAUCE_TUNNEL_ID }} | ||
|
|
||
| - run: yarn sauce:ci | ||
| - run: DISABLE_SYNTHETIC=1 yarn sauce:ci | ||
| - run: LEGACY_BROWSERS=1 yarn sauce:ci | ||
| - run: FORCE_NATIVE_SHADOW_MODE_FOR_TEST=1 yarn sauce:ci | ||
| - run: ENABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE=1 yarn sauce:ci | ||
| - run: ENABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE=1 DISABLE_SYNTHETIC=1 yarn sauce:ci | ||
| - run: API_VERSION=58 yarn sauce:ci | ||
| - run: API_VERSION=58 DISABLE_SYNTHETIC=1 yarn sauce:ci | ||
| - run: DISABLE_ARIA_REFLECTION_POLYFILL=1 DISABLE_SYNTHETIC=1 yarn sauce:ci | ||
| - run: DISABLE_SYNTHETIC_SHADOW_SUPPORT_IN_COMPILER=1 DISABLE_SYNTHETIC=1 yarn sauce:ci | ||
| - run: NODE_ENV_FOR_TEST=production yarn sauce:ci | ||
| - run: NODE_ENV_FOR_TEST=production DISABLE_SYNTHETIC=1 yarn sauce:ci | ||
| - run: yarn hydration:sauce:ci | ||
| - run: yarn coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| name: Run unit tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - release | ||
| - 'spring*' | ||
| - 'summer*' | ||
| - 'winter*' | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| - release | ||
| - 'spring*' | ||
| - 'summer*' | ||
| - 'winter*' | ||
|
|
||
| env: | ||
| PUPPETEER_SKIP_DOWNLOAD: "true" # only needed for @best/runner-local, unused here | ||
|
|
||
| jobs: | ||
| run-unit-tests: | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "18.18.0" | ||
| cache: 'yarn' | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Check missing file headers | ||
| run: node ./scripts/tasks/check-license-headers.js | ||
| - name: Check package.json integrity | ||
| run: node ./scripts/tasks/check-and-rewrite-package-json.js --test | ||
| - name: Verify @lwc/shared is tree-shakable | ||
| run: node ./scripts/tasks/verify-treeshakable.js ./packages/@lwc/shared/dist/index.js | ||
| - name: Verify that dependencies are declared | ||
| run: node ./scripts/tasks/check-imports-are-declared-dependencies.js | ||
| - name: Check formatting | ||
| run: yarn prettier --check '{packages,scripts}/**/*.{js,ts,json,md}' | ||
| - name: Run linter | ||
| run: yarn lint | ||
| - name: Check the size of the LWC bundle | ||
| run: yarn bundlesize | ||
| - name: Run Jest tests | ||
| run: yarn test:ci | ||
| - name: Run benchmark smoke tests | ||
| run: BENCHMARK_SMOKE_TEST=1 yarn test:performance | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #!/usr/bin/env bash | ||
|
There was a problem hiding this comment. Instead of having a custom script to retry, what about using a GH action retry step? There was a problem hiding this comment. I saw this, but I felt uncomfortable since it's not an officially supported Action. |
||
| # | ||
| # Copyright (c) 2023, salesforce.com, inc. | ||
| # All rights reserved. | ||
| # SPDX-License-Identifier: MIT | ||
| # For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT | ||
| # | ||
| # Retry a script multiple times before failing. Used for CI. | ||
| # | ||
|
|
||
| set -e | ||
|
|
||
| export PATH="${PATH}:./node_modules/.bin" | ||
|
|
||
| MAX_RETRY=3 | ||
| n=0 | ||
| until [ $n -ge $MAX_RETRY ] | ||
| do | ||
| echo "Try $[$n+1]/$MAX_RETRY..." | ||
| "$@" && break | ||
| n=$[$n+1] | ||
| done | ||
| if [ $n -ge $MAX_RETRY ]; then | ||
| echo "Failed: ${@}" >&2 | ||
| exit 1 | ||
| fi | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It takes ~1 min to build to build the repo. Is it worth reusing the NX cache between runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have run into numerous issues with NX caching recently (something about stale/invalid artifacts), so we actually disabled it in Nucleus runs.
I'm happy to re-enable it at some point, but saving ~60s is not super important to me right now.