chore: switch from circle ci to github actions #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/nucleus test |
|
Let's hold off until after EF – no reason to rush this |
Merge remote-tracking branch 'origin/master' into nolan/gha
pmdartus
reviewed
Oct 23, 2023
| @@ -0,0 +1,26 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Instead of having a custom script to retry, what about using a GH action retry step?
There was a problem hiding this comment.
I saw this, but I felt uncomfortable since it's not an officially supported Action.
Comment on lines
+35
to
+36
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile |
There was a problem hiding this comment.
It takes ~1 min to build to build the repo. Is it worth reusing the NX cache between runs?
There was a problem hiding this comment.
We have run into numerous issues with NX caching recently (something about stale/invalid artifacts), so we actually disabled it in Nucleus runs.
I'm happy to re-enable it at some point, but saving ~60s is not super important to me right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Does what it says on the tin
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?