Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin chromedriver version for github action #3847

Merged
merged 4 commits into from
Nov 8, 2023
Merged

chore: pin chromedriver version for github action #3847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67e19f7
chore: pin chromedriver version for github action
ravijayaramappa Nov 7, 2023
e100cfe
fix: setup chrome 119
ravijayaramappa Nov 7, 2023
8d3f976
fix: chrome version
ravijayaramappa Nov 8, 2023
0e4e467
fix: pass custom binary to perf script
ravijayaramappa Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ jobs:
node-version: "18.18.0"
cache: 'yarn'

# Needed for perf smoke tests, matches the chromedriver version installed by tachometer(https://github.com/google/tachometer/blob/main/README.md#on-demand-dependencies)
# version number can be found here https://www.googleapis.com/storage/v1/b/chromium-browser-snapshots/o?delimiter=/&prefix=Linux_x64/119
- name: Setup chrome v119
uses: browser-actions/setup-chrome@v1
with:
chrome-version: 1194751
id: setup-chrome

- name: Install dependencies
run: yarn install --frozen-lockfile

Expand All @@ -52,5 +60,4 @@ jobs:
- name: Run Jest tests
run: yarn test:ci
- name: Run benchmark smoke tests
if: ${{ false }} # Disabled until a runner-image with Chrome 119 is available
run: BENCHMARK_SMOKE_TEST=1 yarn test:performance
run: CHROME_BINARY=${{ steps.setup-chrome.outputs.chrome-path }} BENCHMARK_SMOKE_TEST=1 yarn test:performance
2 changes: 2 additions & 0 deletions packages/@lwc/perf-benchmarks/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const {
BENCHMARK_REPO = 'https://github.com/salesforce/lwc.git',
BENCHMARK_REF = 'master',
BENCHMARK_AUTO_SAMPLE_CONDITIONS = '1%', // how much difference we want to determine between A and B
CHROME_BINARY, // if a custom chrome binary is used eg: in CI
} = process.env;
let {
BENCHMARK_SAMPLE_SIZE = 100, // minimum number of samples to run
Expand Down Expand Up @@ -78,6 +79,7 @@ async function createTachometerJson(htmlFilename, benchmarkName, directoryHash)
browser: {
name: 'chrome',
headless: true,
...(CHROME_BINARY && { binary: CHROME_BINARY }),
},
measurement: {
mode: 'performance',
Expand Down