chore: pin chromedriver version for github action #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravijayaramappa
force-pushed
the
ravi/master/W-14449286
branch
3 times, most recently
from
c9ab7eb
to
7577f5b
Compare
ravijayaramappa
force-pushed
the
ravi/master/W-14449286
branch
from
7577f5b
to
8d3f976
Compare
|
Tagging @nolanlawson, for your async review |
divmain
approved these changes
Nov 8, 2023
|
Pinning sounds great to me. But it looks like this will break again when Chrome releases v120, since Tachometer will just install the latest version of Chromedriver. Having our tests break every ~6 weeks is not a great DX. I've opened an issue to track this: #3852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
https://github.com/google/tachometer/blob/main/README.md#on-demand-dependencies
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item