refactor: simplify UpgradableConstructor use of native lifecycle callbacks
#3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| formStateRestoreCallback = (elm: HTMLElement) => { | ||
| runFormStateRestoreCallback(elm); | ||
| }; | ||
| setLifecycleCallbacks({ |
There was a problem hiding this comment.
Since this is a global setting, can we do this one time only instead of in each createElement invocation.
jmsjtu
changed the title
UpgradeableConstructorUpgradableConstructor use of native lifecycle callbacks
nolanlawson
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #3818.
This PR removes the
WeakMapthat stores the lifecycle methods forformAssociatedlifecycle methods which improves performance by ~18%.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?