refactor: simplify lifecycle implementation #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 16, 2023
| callback(this); | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
I also went ahead and DRY'd up this code, although it doesn't turn out to make a perf impact.
nolanlawson
commented
Nov 16, 2023
| @@ -97,6 +98,7 @@ export { | |||
| create, | |||
| defineProperties, | |||
| defineProperty, | |||
| entries, | |||
There was a problem hiding this comment.
Object.entries is supported in all our supported browsers; we had just never used it before.
ravijayaramappa
approved these changes
Nov 16, 2023
jmsjtu
reviewed
Nov 16, 2023
Comment on lines
+8
to
+16
| import { | ||
| LifecycleCallback, | ||
| connectRootElement, | ||
| disconnectRootElement, | ||
| runFormAssociatedCallback, | ||
| runFormDisabledCallback, | ||
| runFormResetCallback, | ||
| runFormStateRestoreCallback, | ||
| } from '@lwc/engine-core'; |
jmsjtu
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I realized we can simplify the implementation by removing
setLifecycleCallbacksentirely and moving everything insidecreate-custom-element.tsin@lwc/engine-dom. It turns out that all the callback functions we need are already exposed by the@lwc/engine-corepackage and can be just imported into@lwc/engine-dom.Tachometer does not report a perf difference between this method and #3862.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?