chore: remove all Circle CI env vars #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 17, 2023
| @@ -29,7 +26,7 @@ function getSauceSection({ suiteName, tags, customData }) { | |||
| throw new TypeError('Missing SAUCE_ACCESS_KEY environment variable'); | |||
| } | |||
|
|
|||
| const buildId = CIRCLE_BUILD_NUM || Date.now(); | |||
| const buildId = GITHUB_RUN_ID || Date.now(); | |||
There was a problem hiding this comment.
Confirmed manually this is getting set correctly, using a console.log.
| commit: CIRCLE_SHA1, | ||
| branch: CIRCLE_BRANCH, | ||
| buildUrl: CIRCLE_BUILD_URL, | ||
| buildId, |
There was a problem hiding this comment.
I don't see the point of all this extra customData. I'm sure nobody ever looks at it anyway.
ekashida
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Guess we were still using some Circle CI env vars. These should have been removed in #3783.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?