Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine-core): fix non-native ARIA reflection [backport] #3919

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

nolanlawson
Copy link
Contributor

@nolanlawson nolanlawson commented Dec 21, 2023

Details

This is just a backport of #3918

W-14784631

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ⚠️ Yes, it does include an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner December 21, 2023 23:09
@nolanlawson nolanlawson force-pushed the nolan/aria-props-fixed-backport branch from a25deb3 to fea6d59 Compare December 21, 2023 23:38
jmsjtu
jmsjtu previously approved these changes Jan 2, 2024
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy

  • Check PR is approved
    PR 3919 is approved

  • Check PR is mergeable
    PR 3919 is mergeable

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v5.0.3. Please commit/push a version bump to the nolan/aria-props-fixed-backport branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 5.0.3 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy

  • Check PR is approved
    PR 3919 is approved

  • Check PR is mergeable
    PR 3919 is mergeable

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v5.0.3. Please commit/push a version bump to the nolan/aria-props-fixed-backport branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 5.0.3 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy

  • Check PR is approved
    PR 3919 is approved

  • Check PR is mergeable
    PR 3919 is mergeable

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v5.0.3. Please commit/push a version bump to the nolan/aria-props-fixed-backport branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 5.0.3 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@nolanlawson nolanlawson merged commit f8732a1 into spring24 Jan 9, 2024
9 of 10 checks passed
@nolanlawson nolanlawson deleted the nolan/aria-props-fixed-backport branch January 9, 2024 18:28
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • ⚪️ Check PR user has rights to execute the workflow (skipped)
    Skipping PR owner check since PR has already been merged.

  • Check PR is approved
    PR 3919 is approved

  • ⚪️ Check PR is mergeable (skipped)
    PR 3919 has already been merged

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v5.0.3. Please commit/push a version bump to the nolan/aria-props-fixed-backport branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 5.0.3 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants