fix(engine-core): fix non-native ARIA reflection #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
reviewed
Dec 22, 2023
packages/@lwc/integration-karma/test/component/aria-reflection/index.spec.js
Outdated
Show resolved
Hide resolved
jmsjtu
approved these changes
Jan 2, 2024
|
@nolanlawson lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #3917
The goal of this PR is to get the behavior of
this.aria*andelm.aria*to work exactly the same as it did in LWC v3 (before we removed the global ARIA polyfill).A new test is added which asserts the pre-v4 behavior, so that we don't regress again.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
Technically yes, the new ARIA props we started supporting in #3702 now behave the same as all the other ARIA props, regardless of whether the browser supports them or not. This is a good thing, since we're allowed to polyfill whatever we want on
LightningElementandBaseBridgeElement, and it's good to be consistent.These new ARIA props are rarely used, and we're exposing new functionality rather than changing existing functionality, so I don't expect any breakages from this.