perf: optimize createUpgradableConstructor
#4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Mar 21, 2024
| // Perf optimization - the vast majority of components have formAssociated=false, | ||
| // so we can skip the setter in those cases, since undefined works the same as false. | ||
| // @ts-expect-error type-mismatch | ||
| UpgradableConstructor.formAssociated = isFormAssociated; |
There was a problem hiding this comment.
This optimization (avoiding setting formAssociated) is tiny compared to the extends optimization, but it still exists. I measured the benefit from this change alone at ~1%:
nolanlawson
commented
Mar 21, 2024
| `<${tagName}> was already registered with formAssociated=${UpgradableConstructor.formAssociated}. It cannot be re-registered with formAssociated=${isFormAssociated}. Please rename your component to have a different name than <${tagName}>` | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not a perf optimization – I just felt it was odd to have this logic inside of the try/finally, since it doesn't strictly need to be there. 🙂
Note that the UpgradableConstructor.formAssociated now has to be cast to a Boolean because it may be undefined.
nolanlawson
commented
Mar 21, 2024
| callback(this); | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
This class is basically hoisted unmodified from the old UpgradableConstructor. The only difference is that it's missing the formAssociated, which has to be different per-class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This optimizes
createUpgradableConstructorand thus improves thedom-light-styled-component-create-1k-differentbenchmark by 6-7%:The main optimization is to avoid creating the same
classwith the same methods/constructor over and over, and to instead justextenda base class.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?