perf(engine-dom): bring back BaseUpgradableConstructor #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This brings back the perf optimization from #4092 which was removed in #4110. This does so safely in a way that doesn't break due to W-15361244 (which I verified manually).
Interestingly, the perf improvement is no longer quite as big – only in the 1-2% range:
It turns out the reason is that the bulk of the original improvement came not from the superclass, but instead from avoiding the for-loop to set all the props on the prototype (nolanlawson@58e45c3):
Either way, this PR is still a perf improvement, and we can do it safely now.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?