Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine-core): fix warnings for invalid keys #4097

Merged
merged 10 commits into from
Mar 26, 2024
Merged

fix(engine-core): fix warnings for invalid keys #4097

merged 10 commits into from
Mar 26, 2024

Commits on Mar 22, 2024

  1. fix(engine-core): fix warnings for invalid keys

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2448984 View commit details
    Browse the repository at this point in the history

  2. fix: fix unnecessary type

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    bceb57a View commit details
    Browse the repository at this point in the history

  3. test: fix error message format

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5328f50 View commit details
    Browse the repository at this point in the history

  4. test: minimal test case

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5a0eac4 View commit details
    Browse the repository at this point in the history

  5. test: use named classes so we can have more precise tests

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c895be8 View commit details
    Browse the repository at this point in the history

  6. test: future-proof the test

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    76ca44b View commit details
    Browse the repository at this point in the history

  7. test: whoops the value does matter

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    acf0665 View commit details
    Browse the repository at this point in the history

  8. refactor: reduce code

    @nolanlawson
    nolanlawson committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1e36e15 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. fix: no isObject

    @nolanlawson
    nolanlawson committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4f08b88 View commit details
    Browse the repository at this point in the history

  2. fix: format

    @nolanlawson
    nolanlawson committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    316186a View commit details
    Browse the repository at this point in the history