chore: nodejs v20 #4131
Merged
chore: nodejs v20 #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
commented
Apr 10, 2024
wjhsf
approved these changes
Apr 11, 2024
nolanlawson
reviewed
Apr 11, 2024
.github/workflows/benchmark.yml
Outdated
| @@ -24,7 +24,7 @@ jobs: | |||
| - name: Setup Node | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: '18.20.1' | |||
| node-version: 20 | |||
There was a problem hiding this comment.
Call me paranoid, but I tend to prefer putting exact version numbers in here. One less thing that might randomly start failing on some random day (especially with backport branches...)
There was a problem hiding this comment.
Yeah, I had an internal debate about this and settled on how it's probably not an issue since Node is super stable in my experience and v20 is LTE on top of that. I don't have a strong opinion on it though.
There was a problem hiding this comment.
Yeah I don't recall being broken by a Node minor/patch version bump, but at this point I don't trust any dependency anymore. 😛
nolanlawson
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Update Node.js to v20.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-15451296