Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: nodejs v20 #4131

Merged
merged 4 commits into from
Apr 11, 2024
Merged

chore: nodejs v20 #4131

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c4ab9f
chore: nodejs v20
ekashida Apr 10, 2024
06ce932
chore: bump minimum node version v16
ekashida Apr 10, 2024
67fd0ff
revert: engines.node
ekashida Apr 10, 2024
6654bec
chore: v20.12.2
ekashida Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18.20.1'
node-version: 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call me paranoid, but I tend to prefer putting exact version numbers in here. One less thing that might randomly start failing on some random day (especially with backport branches...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I had an internal debate about this and settled on how it's probably not an issue since Node is super stable in my experience and v20 is LTE on top of that. I don't have a strong opinion on it though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't recall being broken by a Node minor/patch version bump, but at this point I don't trust any dependency anymore. 😛

cache: 'yarn'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18.20.1'
node-version: 20
cache: 'yarn'

- name: Install dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/karma.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18.20.1'
node-version: 20
cache: 'yarn'

- name: Install dependencies
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18.20.1'
node-version: 20
cache: 'yarn'

- name: Install dependencies
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18.20.1'
node-version: 20
cache: 'yarn'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18.20.1'
node-version: 20
cache: 'yarn'

# Needed for perf smoke tests, matches the chromedriver version installed by tachometer (https://github.com/google/tachometer/blob/main/README.md#on-demand-dependencies)
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@
"node": ">=10"
},
"volta": {
"node": "18.20.1",
"yarn": "1.22.19"
"node": "20.12.1",
"yarn": "1.22.22"
},
"resolutions": {
"//": {
Expand Down