fix(engine-core): handle stylesheets not rendered yet #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
reviewed
Jun 4, 2024
| expectStyles(extractDataIds(elm).paragraph, { | ||
| display: 'block', | ||
| }); | ||
| // Swap blockStyle to inlineStyle, which transitively be swapped to noneStyle |
There was a problem hiding this comment.
Suggested change
| // Swap blockStyle to inlineStyle, which transitively be swapped to noneStyle | |
| // Swap blockStyle to inlineStyle, which will transitively be swapped to noneStyle |
nolanlawson
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
swapStyle() can be called on stylesheets that are yet to be rendered. This is valid especially in the case of salesforce platform where component definitions are (pre-)loaded and can be instantiated in the future, for example dynamic components.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-15890472