Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration-karma): add listener memoization tests #4480

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

nolanlawson
Copy link
Collaborator

Details

This adds Karma tests for event listener memoization, which came up when I was reviewing #4468.

This behavior is a little subtle, and previously we were only really testing it in the template-compiler snapshot tests here:

<template for:each={list} for:item="task">
<li key={task.id}>
{task.title}
<button onclick={task.delete}>[X]</button>
</li>
</template>

Adding the test ensures we don't regress the current functionality.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson merged commit 37b221e into master Aug 27, 2024
11 checks passed
@nolanlawson nolanlawson deleted the nolan/test-memoization branch August 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants