-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scraping changes needed before November 16th - AWS Documentation changes coming #256
Comments
Update: To my surprise, the scraping process still worked by just changing the URL.
Let's assume that will work for now, but might break at some point on or before November 16th. In the meantime, I'll leave this issue open. |
@kmcquade are we on track for this? |
The change just went through last night. Parliament's scraping is broken. I'll look into it on my end. awsdocs/iam-user-guide@0eb32aa |
…ndition Keys. Future-proofed some unit tests to prevent them from breaking after AWS updates their docs. (salesforce#258) Related to salesforce#256
All I had to do for Parliament was specify different URLs: duo-labs/parliament@d371b6b My scraping works now. |
I believe this was fixed by @saikirankv in #258 I'll wait to close this until the automation that updates the documentation runs. Once that PR happens and we can verify it was successful, I will close. |
Fixed by #307 |
…ore-nov-16-2020 Made data scraping changes; fixes to unit tests. Fixes #256
I just got this from the IAM Documentation team (first time I learned there is such a team!)
We chatted a while back about your Policy Sentry code in GitHub that scrapes the IAM Actions, resources, and condition keys documentation. We will delete those pages in 30 days and redirect traffic to the matching page in the new Service Authorization Reference.
Action item: Within the next 30 days, we recommend that you review the policy_sentry code and update it to scrape the new pages. The content format of these new pages and the HTML file names have not changed. If your code supports server redirects, then it should not be affected at all. However, we still recommend that you use the new URL.
Today:
On November 16:
If you have any questions or recommendations for documentation improvements, please let us know.
Thanks,
IAM Documentation
FYI - @aidansteele, @0xdabbad00
The text was updated successfully, but these errors were encountered: