Initial consumer logic, logs the messages for given topic #2
Conversation
There was a problem hiding this comment.
@guptad2 I notice the test directory named __tests__. Is there a reason for adding underscores? Is that a standard practice for node.js projects? Curious because it looks a bit different than other node.js projects we have.
|
@pallavi2209 The testing framework used here uses this regular expression to detect the test files. "**/__tests__/**/*.[jt]s?(x)", "**/?(*.)+(spec|test).[jt]s?(x)" So it was either naming the directory __tests__ or naming files fileName.test.js |
src/handlerUtil.js
Outdated
| messageSet.forEach((m) => { | ||
| const key = m.message.key; | ||
| const value = m.message.value; | ||
| logger.info('Message from topic', topic, key, value); |
There was a problem hiding this comment.
We should consider structuring this output a little better, e.g. both sumo and pino support log lines as json object, and having that kind of structure might be nice to have e.g. set up topic and key as "properties" on the pino log item... ?
There was a problem hiding this comment.
But we can make that a separate story if you want
There was a problem hiding this comment.
Yea I was thinking to make it a separate story after we can spec out the log format in detail? Because I am not too sure how the later use case would work (storing logs in a big data store + pub/sub aggregation) and I guess the structure of the logs and how we handle them would depend on that?
… into init-consumer
Some problem with init-changes. This contents of this branch are the same as init-changes.