edit perspectives #236

annyhe · 2017-02-03T18:30:53Z

No description provided.

coveralls · 2017-02-03T18:36:41Z

Coverage remained the same at 86.266% when pulling 56be1f1 on mainPersBr into 6355731 on master.

coveralls · 2017-02-03T18:39:18Z

Coverage remained the same at 86.266% when pulling 56be1f1 on mainPersBr into 6355731 on master.

coveralls · 2017-02-03T18:39:41Z

Coverage remained the same at 86.266% when pulling 56be1f1 on mainPersBr into 6355731 on master.

coveralls · 2017-02-08T21:49:26Z

Coverage remained the same at 86.177% when pulling eb707aa on mainPersBr into a7d599d on master.

coveralls · 2017-02-08T21:50:44Z

Coverage remained the same at 86.177% when pulling eb707aa on mainPersBr into a7d599d on master.

iamigo

Can we get it look at it in a review app?

iamigo · 2017-02-09T00:28:13Z

tests/view/components/createPerspective.js

+      expect(instance.state.dropdownConfig.subjects.options.length).to.equal(ZERO);
+    });
+
+    it.skip('field subject tag filter array is populated from props',


iamigo · 2017-02-09T00:29:12Z

tests/view/components/utils.js

@@ -0,0 +1,31 @@
+


needs copyright header block

iamigo · 2017-02-09T00:29:27Z

tests/view/components/utils.js

+
+module.exports = {
+  getSubjects,
+}


needs trailing carriage return

implemented changes

coveralls · 2017-02-09T00:46:04Z

Coverage remained the same at 86.177% when pulling 3915af8 on mainPersBr into a7d599d on master.

coveralls · 2017-02-09T00:46:41Z

Coverage remained the same at 86.177% when pulling 3915af8 on mainPersBr into a7d599d on master.

coveralls · 2017-02-09T00:50:14Z

Coverage remained the same at 86.177% when pulling 3915af8 on mainPersBr into a7d599d on master.

coveralls · 2017-02-09T00:51:44Z

Coverage remained the same at 86.177% when pulling 3915af8 on mainPersBr into a7d599d on master.

annyhe · 2017-02-09T00:55:45Z

@iamigo I deployed a review app just now. Takes a few minutes to setup and push data to it.

annyhe · 2017-02-09T01:10:58Z

@iamigo @meynet Review app is live at http://refocus-pr-243.herokuapp.com/perspectives/ppppp

iamigo

working very nicely!

laf doesn't seem fully "lightning-y" -- I can explain better in person or on a hangout--let's go over it together tom'w

coveralls · 2017-02-09T18:04:39Z

Coverage remained the same at 86.177% when pulling 74fa9b0 on mainPersBr into a7d599d on master.

annyhe · 2017-02-09T18:12:29Z

travis CI choked on api test: might be a flapping test as none of the changes affect the API. Will do another PR after going over the UI changes with Ian, and the tests should pass.

coveralls · 2017-02-09T18:19:24Z

Coverage remained the same at 86.177% when pulling 120e7d4 on mainPersBr into 2f27d36 on master.

pallavi2209 · 2017-02-09T20:12:01Z

@annyhe I cant see Edit/pencil option on review app. Let me know once this is deployed, I would like to playaround :)

annyhe · 2017-02-09T21:59:40Z

@pallavi2209 I am deploying to a new review app. The old one doesn't accept new commits.

coveralls · 2017-02-10T17:43:52Z

Coverage remained the same at 86.091% when pulling 360616b on mainPersBr into 9a8a8c2 on master.

coveralls · 2017-02-10T17:44:17Z

Coverage remained the same at 86.091% when pulling 360616b on mainPersBr into 9a8a8c2 on master.

annyhe · 2017-02-10T17:54:07Z

Updated as per Ian's UI comments

coveralls · 2017-02-10T17:58:23Z

Coverage remained the same at 86.091% when pulling 83b9ade on mainPersBr into 9a8a8c2 on master.

coveralls · 2017-02-10T18:47:43Z

Coverage remained the same at 86.091% when pulling 7de39ac on mainPersBr into 9a8a8c2 on master.

coveralls · 2017-02-10T18:58:39Z

Coverage remained the same at 86.091% when pulling 81279a7 on mainPersBr into 9a8a8c2 on master.

annyhe · 2017-02-10T21:33:53Z

DO NOT merge: the css on https://www.lightningdesignsystem.com/components/menus/#flavor-dropdown-dropdown-menu-icon-double differs from the one we use, so the dropdown styles are messed up. Will update when it gets fixed.

annyhe · 2017-02-10T22:04:27Z

@iamigo @pallavi2209 The css mess is fixed. Please review demo app http://refocus-pr-236.herokuapp.com/perspectives/sdsdsds

annyhe · 2017-02-10T22:05:46Z

view/admin/components/common/Dropdown.js

@@ -179,7 +179,7 @@ class Dropdown extends React.Component {
    let outputUL = '';
    // if options exist, load them
    if (data.length) {
-      outputUL = <ul className="slds-dropdown__list" role="menu">
+      outputUL = <ul className="slds-lookup__list" role="menu">


This css class is essential to have the two column effect. Otherwise the icon, text, and icon on the right all float to the left.

It looks like the "New Perspective" label is not aligned with the names of the perspectives--it looks a few pixels to the right.

Is that easy to tweak? If not, I'm ready to move on :)

Can we move on? If it really bothers people we can fix it later.

coveralls · 2017-02-10T22:06:46Z

Coverage remained the same at 86.091% when pulling 98a7a9e on mainPersBr into 9a8a8c2 on master.

pallavi2209 · 2017-02-10T22:53:16Z

So, when I am on /perspective page, and I delete/add some subjects, and then I try and edit a perspective, should I get updated list of subjects in Root subject dropdown? @annyhe @iamigo

Other than that, the review app looks good.

annyhe · 2017-02-10T22:56:25Z

@pallavi2209 After refreshing the page you ought to get the list of updated subjects. subjects are set on page load.

annyhe force-pushed the mainPersBr branch 2 times, most recently from 734dd1d to 56be1f1 Compare February 3, 2017 18:33

meynet-salesforce temporarily deployed to refocus-pr-236 February 3, 2017 18:35 Inactive

annyhe changed the title ~~DO NOT MERGE edit perspective~~ edit perspectives Feb 8, 2017

annyhe requested review from iamigo and pallavi2209 February 8, 2017 22:56

iamigo previously requested changes Feb 9, 2017

View reviewed changes

annyhe force-pushed the mainPersBr branch 2 times, most recently from a03b369 to 8febbc9 Compare February 9, 2017 00:44

iamigo reviewed Feb 9, 2017

View reviewed changes

annyhe force-pushed the mainPersBr branch from 3915af8 to d356162 Compare February 9, 2017 17:55

meynet-salesforce temporarily deployed to refocus-pr-236 February 9, 2017 21:58 Inactive

annyhe temporarily deployed to refocus-pr-236 February 9, 2017 21:59 Inactive

annyhe had a problem deploying to refocus-pr-236 February 10, 2017 17:37 Failure

annyhe had a problem deploying to refocus-pr-236 February 10, 2017 17:38 Failure

implement edit perspective

83b9ade

annyhe force-pushed the mainPersBr branch from 360616b to 83b9ade Compare February 10, 2017 17:49

annyhe had a problem deploying to refocus-pr-236 February 10, 2017 17:49 Failure

annyhe added 3 commits February 10, 2017 10:09

wont go into another page

19b34ca

removed field checking

be0b7be

remove old functions

7de39ac

annyhe requested a deployment to refocus-pr-236 February 10, 2017 18:41 Pending

fix minor bug

81279a7

annyhe had a problem deploying to refocus-pr-236 February 10, 2017 18:52 Failure

meynet-salesforce temporarily deployed to refocus-pr-236 February 10, 2017 21:06 Inactive

update style to fix messed up indentation

98a7a9e

annyhe deployed to refocus-pr-236 February 10, 2017 22:01 View deployment

annyhe commented Feb 10, 2017

View reviewed changes

iamigo approved these changes Feb 10, 2017

View reviewed changes

pallavi2209 approved these changes Feb 10, 2017

View reviewed changes

pallavi2209 merged commit 05779c0 into master Feb 10, 2017

pallavi2209 deleted the mainPersBr branch February 10, 2017 23:10

edit perspectives #236

edit perspectives #236

Conversation

annyhe commented Feb 3, 2017 • edited Loading

coveralls commented Feb 3, 2017

coveralls commented Feb 3, 2017

coveralls commented Feb 3, 2017

coveralls commented Feb 8, 2017

coveralls commented Feb 8, 2017

iamigo left a comment

Choose a reason for hiding this comment

iamigo Feb 9, 2017

Choose a reason for hiding this comment

iamigo Feb 9, 2017

Choose a reason for hiding this comment

iamigo Feb 9, 2017

Choose a reason for hiding this comment

coveralls commented Feb 9, 2017

coveralls commented Feb 9, 2017

coveralls commented Feb 9, 2017

coveralls commented Feb 9, 2017

annyhe commented Feb 9, 2017

annyhe commented Feb 9, 2017

iamigo left a comment

Choose a reason for hiding this comment

coveralls commented Feb 9, 2017

annyhe commented Feb 9, 2017

coveralls commented Feb 9, 2017

pallavi2209 commented Feb 9, 2017

annyhe commented Feb 9, 2017

coveralls commented Feb 10, 2017

coveralls commented Feb 10, 2017

annyhe commented Feb 10, 2017

coveralls commented Feb 10, 2017

coveralls commented Feb 10, 2017

coveralls commented Feb 10, 2017

annyhe commented Feb 10, 2017

annyhe commented Feb 10, 2017

annyhe Feb 10, 2017

Choose a reason for hiding this comment

iamigo Feb 10, 2017

Choose a reason for hiding this comment

iamigo Feb 10, 2017

Choose a reason for hiding this comment

annyhe Feb 10, 2017

Choose a reason for hiding this comment

coveralls commented Feb 10, 2017

pallavi2209 commented Feb 10, 2017 • edited Loading

annyhe commented Feb 10, 2017

annyhe commented Feb 3, 2017 •

edited

Loading

pallavi2209 commented Feb 10, 2017 •

edited

Loading