fix bug of subject admin page rewriting subject name as #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamigo
previously requested changes
Feb 14, 2017
view/admin/utils/getFormData.js
Outdated
| @@ -154,14 +179,15 @@ function getFormData(form, aspectRangeFormat, propertyMetaData) { | |||
| if (aspectRangeFormat === 'BOOLEAN') { | |||
| fromBooleanInput(inputs, jsonData); | |||
| } else if (aspectRangeFormat === 'NUMERIC') { | |||
| fromTextInput(inputs, jsonData, function(value) { | |||
| fromTextInput(inputs, jsonData, (value) => { | |||
There was a problem hiding this comment.
fromTextInput(inputs, jsonData, (value) => parseFloat(value));
view/admin/utils/getFormData.js
Outdated
| return parseFloat(value); | ||
| }); | ||
| } else if (aspectRangeFormat === 'PERCENT') { | ||
| fromTextInput(inputs, jsonData, function(value) { | ||
| return value/100; | ||
| fromTextInput(inputs, jsonData, (value) => { |
There was a problem hiding this comment.
fromTextInput(inputs, jsonData, (value) => value / 100);
| @@ -80,9 +85,19 @@ function fromTextInput(inputs, jsonData, alterDataFunc) { | |||
| * @returns {Object} with keys to particular DOM elements | |||
| */ | |||
| function getInputsAndSelects(form) { | |||
There was a problem hiding this comment.
Any way to add a test for this fix?
There was a problem hiding this comment.
There are ways but they are verbose to write and maintain. The crux of the method is node.contains, which is well-documented https://developer.mozilla.org/en-US/docs/Web/API/Node/contains
|
Demo app deployed to http://refocus-pr-249.herokuapp.com/subjects |
annyhe
force-pushed
the
fixSubjectAdmin
branch
from
0670a36
to
beecc07
Compare
iamigo
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relatedLinks name