removed rejection and unnecessary test cases as well #70
Conversation
harshkothari410
commented
Oct 24, 2016
harshkothari410
commented
- Fixed broken test
- Removed all rejection error except one
- Removed unnecessary testcases / duplication test cases
|
Unhandled rejection SequelizeForeignKeyConstraintError: insert or update on table "Subjectsancestors" violates foreign key constraint "Subjectsancestors_SubjectId_fkey" Rejection is remaining. I am doing research for that. This is happening from sequelize file. |
| @@ -47,7 +47,8 @@ function augmentSampleWithSubjectInfo(seq, inst) { | |||
| inst.dataValues.subject = sub; | |||
|
|
|||
| // adding absolutePath to sample instance | |||
| inst.dataValues.absolutePath = sub.absolutePath; | |||
| if (sub) | |||
There was a problem hiding this comment.
please remember to run gulp style before submitting pr
we enclose all ifs--even single-line blocks--in curly braces
|
i'd like one more review on these changes, @pallavi2209 and/or @shriramshankar, thx! |
| .equal('geolocation'); | ||
| done(); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Why are we removing these tests ?
There was a problem hiding this comment.
Those test cases are redundant . Its already there.
There was a problem hiding this comment.
Ok. Also, the code coverage has decreased, any ideas why?
There was a problem hiding this comment.
It was increased initially but due to some PR that is merged in master and then master merged it to this branch then it is decreased.
