Based on node securiy feedback, update affected dependencies. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annyhe
changed the title
|
Keep backing out changes 'til the build works again :( |
|
@pallavi2209 @iamigo This pull request is failing due to node security errors, and passing the original CI tests. Please review. |
iamigo
approved these changes
Oct 27, 2016
| @@ -44,7 +49,7 @@ describe('ControlledInput Test', () => { | |||
| it('on input with new props, expect name and input value to be updated'); | |||
|
|
|||
| // use ReactDOM.findDOMNode, not inputField directly, in Simulate.change | |||
| it.skip('on change, input value updates to new value', () => { | |||
| it('on change, input value updates to new value', () => { | |||
|
Thanks Ian. Any comments or concerns @pallavi2209 ? |
|
This is one where we'll want to give it some extra diligence with manual testing in staging (esp. bulk upserts and socket.io communication) to make sure those dependency updates don't unintentionally break any of our core functionality which is harder to tease out from our unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got 8 security vulnerabilities down to five. The remaining security errors exist due to package minimatch in mocha (breaking changes if update), gulp, and sequelize-cli (for db migration scripts).