Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compress all static resource #75

Merged
merged 2 commits into from
Nov 1, 2016
Merged

compress all static resource #75

merged 2 commits into from
Nov 1, 2016

Conversation

shriramshankar
Copy link
Contributor

@shriramshankar shriramshankar commented Oct 30, 2016 •
edited
Loading

moved compression to the top of the index.js file, so that all the resources are compressed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 83.093% when pulling d3c32f2 on gzip-static-resource into e12f31e on master.

@annyhe
Copy link
Contributor

annyhe commented Oct 31, 2016

@harshkothari410 With this change, which additional files are compressed?

@shriramshankar
Copy link
Contributor Author

@annyhe all the static files are compressed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 83.093% when pulling 0d637ac on gzip-static-resource into 9e81570 on master.

@shriramshankar
Copy link
Contributor Author

@annyhe or @harshkothari410 can one of you review and merge it?

@annyhe
Copy link
Contributor

annyhe commented Oct 31, 2016

@harshkothari410 please add a comment on the code to say the line needs to be there. Otherwise future devs may move the line down.

@coveralls
Copy link

coveralls commented Oct 31, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 83.006% when pulling 484717c on gzip-static-resource into 9e81570 on master.

@shriramshankar shriramshankar temporarily deployed to refocus-staging October 31, 2016 22:10 Inactive
@shriramshankar
Copy link
Contributor Author

shriramshankar commented Oct 31, 2016 •
edited
Loading

@iamigo @annyhe updated the PR with comments. The app.js loads about a second faster with this change on Staging.

@iamigo iamigo merged commit c21ddd3 into master Nov 1, 2016
@iamigo iamigo deleted the gzip-static-resource branch November 1, 2016 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshkothari410 harshkothari410 harshkothari410 approved these changes

@iamigo iamigo iamigo approved these changes

Assignees

@harshkothari410 harshkothari410

@iamigo iamigo

@annyhe annyhe

Labels
scalability and/or performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shriramshankar @coveralls @annyhe @harshkothari410 @iamigo