Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the problem where the value of DISABLE_HTTP would be ignored #80

Merged
merged 1 commit into from
Nov 2, 2016
Merged

fix the problem where the value of DISABLE_HTTP would be ignored #80

merged 1 commit into from
Nov 2, 2016

Conversation

iamigo
Copy link
Contributor

@iamigo iamigo commented Nov 2, 2016

No description provided.

@iamigo iamigo added the bug label Nov 2, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 83.195% when pulling fc037da on fixDisableHttpConfig into a50c47f on master.

@pallavi2209
Copy link
Contributor

@iamigo Do you think we can improve test coverage by having a test for toggle.js? Possible?

@iamigo
Copy link
Contributor Author

iamigo commented Nov 2, 2016

Test coverage isn't measuring all the tests yet so we can't trust these percentages. There's a story to fix the "test" script in package.json.

@shriramshankar shriramshankar merged commit 81c4c19 into master Nov 2, 2016
@iamigo iamigo deleted the fixDisableHttpConfig branch November 2, 2016 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pallavi2209 pallavi2209 pallavi2209 approved these changes

@shriramshankar shriramshankar shriramshankar approved these changes

Assignees

@pallavi2209 pallavi2209

@shriramshankar shriramshankar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamigo @coveralls @pallavi2209 @shriramshankar