Fix migration issue #81
Conversation
| models.sequelize.query(`select count(*) from | ||
| information_schema.tables where table_schema = 'public'`) | ||
| .then((data) => { | ||
| console.log('found', data) | ||
| console.log('found', data); // eslint-disable-line |
There was a problem hiding this comment.
I added this when troubleshooting migration issues a while back. We don't need to keep this console.log anymore either, unless it's useful to you for migration troubleshooting
There was a problem hiding this comment.
Removing this as well.
| const dbConfig = utils.dbConfigObjectFromDbURL(); | ||
| console.log('create db now', dbConfig) | ||
| console.log('create db now', dbConfig); // eslint-disable-line |
There was a problem hiding this comment.
we don't need to keep this console.log anymore either, unless it's useful to you for migration troubleshooting
There was a problem hiding this comment.
Okies sure I am removing this.
|
@harshkothari410 does this fix the migration issues @meynet hit in heroku? |
|
Yeah I tested on Heroku so I am assuming that it is fixed. |
|
@harshkothari410 Resolve conflicts please. |
|
Is there any specific script we have for sequelize.sync({ force: false }) ? @pallavi2209 |
|
No. We need to add a call to sequelize sync from the doImport function in db/index.js. |
|
Nevermind, I noticed a related story on Ian's dashboard for this sprint. Can you resolve conflicts in package.json for this PR? @harshkothari410 |
|
@harshkothari410 please let me know if you need help resolving the package.json conflicts so we can get this merged. |
Here I removed the checkDB functionality into postinstall and added to prestart. So that there is no issue of private space heroku migration / resetdb issue.
There will be little bit overhead on npm start but it results in lots of simplicity in automatic migration and deployment of new refocus on any platform.