Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Customizable view dimensions #13

Merged
merged 3 commits into from
Aug 18, 2016
Merged

Customizable view dimensions #13

merged 3 commits into from
Aug 18, 2016

Conversation

vidbina
Copy link
Contributor

@vidbina vidbina commented Jul 4, 2016

Grant user more control over the dimensions of the view

let View = (controller, svg, module) => {
  // ...
  return({
    width: 1200,
    height: 800,
    customView: true, // needed to specify that our viewport has custom dimensions in order to properly set the viewBox attribute
    update: () => {
      // update logic
    }
  });
};

@ongardie-sfdc ongardie-sfdc mentioned this pull request Jul 5, 2016
@ongardie-sfdc
Copy link
Collaborator

Yep, that's probably better than bigView, wideView, bigWideView, biggerNarrowView, etc... :)

Thanks!

@ongardie-sfdc ongardie-sfdc merged commit 43d611b into salesforce:master Aug 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants