Presentation mode #14
Conversation
@andi-tmh complained about the buttons not being user-friendly which explains why I introduced a regular "play" button which should make it easier to click.
|
Thanks, @vidbina. I do like the new buttons. Do you mind removing the old, now hidden, checkbox? I don't think it's needed in many places. Before I can merge this and your other PR (#13), we need a CLA (Contributor's License Agreement) from you or The Mobility House, as appropriate. You can find the CLA here; please send the completed form to osscore@salesforce.com. You only need to do this once; it'll be valid for any Salesforce project. Feel free to email that list (which I'm on) with questions. Sorry for the hurdle, but I look forward to merging this and continuing to collaborate on Runway. |
|
@vidbina got your CLA, thanks. Could you remove that hidden checkbox? |
|
On it On Aug 17, 2016 20:40, "Diego Ongaro" notifications@github.com wrote:
|
I just needed some state to indicate if the simulation is running or not. During the initialization phase I setup the play button to the starting state (show the play symbol) since I assume runway-browser does not init to a running sim, furthermore I call toggle(cb) on every click and check the sim state within toggle to start or stop the sim. I call the callback with the playing state (true is running, false is stopped) to take care of updating the UI.
|
Merged, thanks @vidbina! |
Better buttons since @andi-tmh is running into a lot of issues while demoing runway setups on a beamer. The buttons should make the experience less painful, furthermore @andi-tmh propsed a details button which hides the the tabs containing the state tables.