Add negative numbers (and ranges). #10
Conversation
I also added a radix to `parseInt` -- best practice, especially when using it as a callback to `map`. Test plan: `npm test` runs successfully. However, I'm not especially confident that precedence is right in all cases.
|
Thanks @joelburget, seems like a good thing to have, though personally I've been trying to avoid negative numbers whenever possible. Salesforce needs a CLA from you/your employer before I can merge any PRs. I explained the process recently over in salesforce/runway-browser#14. Sorry for the hurdle. Hopefully it's no big deal, and I'll be happy to merge this once that's done. |
|
@ongaedie-sfdc Maybe setup https://github.com/clabot/clabot to automate the CLA process? |
|
@dgryski thanks, we're actually working on that already. It's a known pain point and it's high on the priority list for our osscore team. Not sure if it's using clabot or something else, but it's getting pretty close. There's just a few loose ends, including getting an "official" subdomain & cert to run it with, so I'm not sure when it'll launch. |
I also added a radix to
parseInt-- best practice, especially whenusing it as a callback to
map.Test plan:
npm testruns successfully. However, I'm not especially confident thatprecedence is right in all cases.