Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MemoryCookieStore methods should exist on the prototype, not on the class. #226

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Nov 18, 2021

Also some linter auto-fixes adding noise to the test file. 😐 The test that I added starts on line 249.

Copy link
Contributor

@colincasey colincasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. @awaterma i see you're attached to the PR that introduced this code. can you comment?

Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@awaterma
Copy link
Member

awaterma commented Dec 1, 2021

Thank you for the contribution @wjhsf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants