chore(package): update dependencies #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -25,14 +25,14 @@ | |||
| "@types/chai": "4.2.11", | |||
| "@types/jsforce": "^1.9.18", | |||
| "@types/mocha": "^7.0.2", | |||
| "@types/node": "^13.13.2", | |||
| "@types/node": "^16.0.2", | |||
There was a problem hiding this comment.
This dependency is also being updated in the other PR(https://github.com/salesforce/sfdx-plugin-lwc-test/pull/30/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R28)
There was a problem hiding this comment.
Oops, my mistake. I'll fix the merge conflict when I merge.
|
All the three other PRs are touching yarn.lock and might run into merge conflicts. May be combine the updates into one PR would eliminate some of this overhead. |
pmdartus
approved these changes
Jul 9, 2021
|
@ravijayaramappa I did multiple PRs to try to isolate what's breaking. But yes it could all be one big PR. |
nolanlawson
force-pushed
the
nolan/update-typescript
branch
from
f110c00
to
0b7c9cc
Compare
nolanlawson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we can't upgrade to TypeScript v4 yet because that breaks something in sfdx-core. But we can upgrade the other stuff.