Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep support for stat file v1? #231

Closed
saltzberg opened this issue Apr 5, 2017 · 5 comments
Closed

Keep support for stat file v1? #231

saltzberg opened this issue Apr 5, 2017 · 5 comments
Labels

Comments

@saltzberg
Copy link

Do we need to keep support for stat file v1 in the new PMI release?

If not, I can remove this as I update ProcessOutput.

@benmwebb
Copy link
Member

benmwebb commented Apr 5, 2017

Yes, please don't break any more PMI stuff for now. I just got it all working! I'll be making a new release in the next week or so.

@saltzberg
Copy link
Author

Duly noted =)

@benmwebb
Copy link
Member

benmwebb commented Apr 5, 2017

Also, of course, we try not to simply remove stuff. It should be deprecated for one stable release and removed in the next (and noted in the changelog). Removing stuff without telling people is super annoying!

I'll see if I can slip a deprecation warning for old statfiles in before the upcoming release.

@saltzberg
Copy link
Author

saltzberg commented Apr 5, 2017 via email

@benmwebb
Copy link
Member

benmwebb commented Apr 5, 2017

The 'official' deprecation macros are only for functions and classes, so for a deprecated file format, just print a warning message. For Python code, here's an example (this is for old-style topology files). For C++ code, use IMP_WARN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants