trickle ice #45
Merged
trickle ice #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebSockets make it easier to do trickle ICE, which in turn gives us a much faster WebRTC handshake. It's also much more reliable with some browser combinations for reasons that I do not understand. https://tools.ietf.org/html/draft-ietf-ice-trickle-21 This only adds the server parts.
This also adds some more console logging for the pake and webrtc handshakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Websockets make it easier to do trickle ICE, which in turn gives us
a much faster WebRTC handshake. It's also way more reliable with
some browser combinations for reasons that I do not understand.
This is breaking change and once deployed people using the command
line client would need to upgrade.
https://tools.ietf.org/html/draft-ietf-ice-trickle-21
This also adds a bunch more console logging in the web client.
Try it at https://tip.webwormhole.io/ and let me know.