Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Deprecate Send And Retry Method #379

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

Sammyjo20
Copy link
Collaborator

This PR deprecates the old sendAndRetry method in Saloon as it goes against Saloon's class-based pattern. You are still able to define retry functionality but you can now do this from within the connector or request class by using the $tries property.

@Sammyjo20 Sammyjo20 marked this pull request as ready for review February 25, 2024 14:10
Copy link
Collaborator Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 merged commit e74c30a into v3 Feb 25, 2024
14 checks passed
@Sammyjo20 Sammyjo20 deleted the feature/deprecate-send-and-retry-method branch March 19, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant