Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tracing instead of log #516

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

davidbarsky
Copy link
Contributor

Besides my well-known biases, rust-analyzer uses tracing, and given how big of a difference Salsa 3.0 it, I figured it makes sense to switch over.

(We switched over a few months back in rust-analyzer's vendored fork of Salsa.)

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 86f06d8
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/669ed7d88b1ae300082c5444

@nikomatsakis
Copy link
Member

@davidbarsky I'm happy-ish to merge this PR (I'm a bit grumpy that we don't have a clearer standard in Rust land, but that's neither your fault nor tracing's, really) but it needs a rebase =)

@davidbarsky
Copy link
Contributor Author

@davidbarsky I'm happy-ish to merge this PR (I'm a bit grumpy that we don't have a clearer standard in Rust land, but that's neither your fault nor tracing's, really) but it needs a rebase =)

Rebased! And yeah: I think they occupy their own, slightly distinct niches at this point (particularly from an FFI perspective), but I wouldn't mind resolving those gaps.

@nikomatsakis nikomatsakis added this pull request to the merge queue Jul 23, 2024
Merged via the queue into salsa-rs:master with commit 2f4f80f Jul 23, 2024
7 of 8 checks passed
@MichaReiser
Copy link
Contributor

I'm not sure if it is intentional but this log can blow up, depending on the value (in our case, it logs the entire AST 😆).

https://github.com/MichaReiser/salsa/blob/2f4f80fe23cfb968ffe58fdf99aa77eacf6dbf9a/src/function/maybe_changed_after.rs#L109

Should we exclude the value from the Memo's Debug impl?

@davidbarsky
Copy link
Contributor Author

I'm not sure if it is intentional but this log can blow up, depending on the value (in our case, it logs the entire AST 😆).

https://github.com/MichaReiser/salsa/blob/2f4f80fe23cfb968ffe58fdf99aa77eacf6dbf9a/src/function/maybe_changed_after.rs#L109

Should we exclude the value from the Memo's Debug impl?

@MichaReiser Yes, it's probably a good idea to exclude it. sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants