chore: enable no-confusing-void-expression (#978)

.eslintrc.cjs

@@ -85,7 +85,6 @@ module.exports = defineConfig({
 
     // TODO @Shinigami92 2024-02-29: Remove these later
     '@typescript-eslint/no-base-to-string': 'off',
-    '@typescript-eslint/no-confusing-void-expression': 'off',
     '@typescript-eslint/no-floating-promises': 'off',
     '@typescript-eslint/no-implied-eval': 'off',
     '@typescript-eslint/no-redundant-type-constituents': 'off',

src/db.ts

@@ -69,11 +69,12 @@ const db = (
           if (err) {
             connectionStatus = ConnectionStatus.ERROR;
             logger.error(`could not connect to postgres: ${inspect(err)}`);
-            return reject(err);
+            reject(err);
+            return;
           }
 
           connectionStatus = ConnectionStatus.CONNECTED;
-          return resolve();
+          resolve();
         });
       }
     });
@@ -144,9 +145,9 @@ ${err}
     close: async () => {
       await beforeCloseListeners.reduce(
         (promise, listener) =>
-          promise
-            .then(listener)
-            .catch((err: any) => logger.error(err.stack || err)),
+          promise.then(listener).catch((err: any) => {
+            logger.error(err.stack || err);
+          }),
         Promise.resolve()
       );
       if (!isExternalClient) {

src/runner.ts

@@ -311,7 +311,9 @@ export default async (options: RunnerOption): Promise<RunMigration[]> => {
   } finally {
     if (db.connected()) {
       if (!options.noLock) {
-        await unlock(db).catch((error) => logger.warn(error.message));
+        await unlock(db).catch((error) => {
+          logger.warn(error.message);
+        });
       }
 
       db.close();

src/sqlMigration.ts

@@ -29,8 +29,15 @@ export const getActions = (content: string): MigrationBuilderActions => {
       : undefined;
 
   return {
-    up: (pgm) => pgm.sql(upSql),
-    down: downSql === undefined ? false : (pgm) => pgm.sql(downSql),
+    up: (pgm) => {
+      pgm.sql(upSql);
+    },
+    down:
+      downSql === undefined
+        ? false
+        : (pgm) => {
+            pgm.sql(downSql);
+          },
   };
 };