chore: enable throw-literal

salsita · Mar 3, 2024 · f0ccdec · f0ccdec
1 parent 429d01d
commit f0ccdec
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -86,8 +86,6 @@ module.exports = defineConfig({
     // TODO @Shinigami92 2024-02-29: Remove these later
     '@typescript-eslint/no-base-to-string': 'off',
     '@typescript-eslint/no-floating-promises': 'off',
-    '@typescript-eslint/no-redundant-type-constituents': 'off',
-    '@typescript-eslint/no-throw-literal': 'off',
     '@typescript-eslint/no-unsafe-argument': 'off',
     '@typescript-eslint/no-unsafe-return': 'off',
     '@typescript-eslint/no-var-requires': 'off',

diff --git a/test/migrations/081_temporary_table.js b/test/migrations/081_temporary_table.js
@@ -6,14 +6,13 @@ exports.up = (pgm) => {
 
 exports.down = async (pgm) => {
   await pgm.db.query('SAVEPOINT sp_temp_table;');
+
   try {
     await pgm.db.query('DROP TABLE "tmp"');
-    throw 1;
-  } catch (err) {
-    if (err === 1) {
-      throw new Error('Missing TEMPORARY clause');
-    }
-
+  } catch {
     await pgm.db.query('ROLLBACK TO SAVEPOINT sp_temp_table;');
+    return;
   }
+
+  throw new Error('Missing TEMPORARY clause');
 };