dropIndex doesn't generate the correct name for a unique index

[georgeroman]

Unique indexes created via createIndex(table, column, { unique: true }) get assigned a name following the pattern: table_column_unique_index. However, when the same index needs to be dropped via dropIndex, there is no option to specify that the index is unique and so dropIndex will try to drop the index named table_column_index which is different than what we want. A fix for this would add a unique option to dropIndex so that it can generate the correct index name.

[littlewhywhat]

hi @georgeroman!

Yes, i see the problem.

While we fixing it - some other options to consider for you:

• you can provide the name explicitly via name option. Smth like this should work:

pgm.createIndex('table', ['col1', 'col2'], { name: 'example_index' })

pgm.dropIndex('table', ['col1', 'col2'], { name: 'example_index' })

• it should work at the moment if you let node-pg-migrate to generate down migration (by not exporting down function from your migration file).

[littlewhywhat]

@georgeroman one other note - the fix seems to be just in type - so if you ignore ts error or use js then you can just provide { unique: true } option to dropIndex and it should work as well:

pgm.dropIndex('table', ['col1', 'col2'], { unique: true })

[littlewhywhat]

Fix is realized in https://github.com/salsita/node-pg-migrate/releases/tag/v6.1.0.

Thank you!

[georgeroman]

Perfect, thank you for the quick response and fix!