fix(runner): resolve migration file for esm #1207
Conversation
|
@aprendendofelipe could you do a review for this? |
Shinigami92
force-pushed
the
fix-esm-resolve-migration-file-in-runner
branch
3 times, most recently
from
0721729
to
9a3a8f8
Compare
Shinigami92
force-pushed
the
fix-esm-resolve-migration-file-in-runner
branch
4 times, most recently
from
cfdb4da
to
5bc0b7b
Compare
|
Okay... I need more time to find out what's going on 😕 but ran out of time today |
src/runner.ts
Outdated
| const relativeFilePath = relative(directory, filePath); | ||
|
|
||
| return ( | ||
| globalThis.require?.(relativeFilePath) ?? (await import(relativeFilePath)) |
There was a problem hiding this comment.
import will not work with .ts at runtime.
What do you think about #1206:
const filePath = resolve(options.dir, file);
const actions: MigrationBuilderActions =
extname(filePath) === '.sql'
? await migrateSqlFile(filePath)
: createRequire(resolve('noop.js'))(filePath);There was a problem hiding this comment.
First, pls read all my comments in your other PR 🙂
But regarding .ts files, I was shocked a bit to discover what's really going on here 🤔 (I just took over maintenance and I'm not the original creator)
When we will go full esm only in v9, I thought that we will import the migration file and consume it as a real js file. But now there is potential also .ts files at runtime? 👀
Either we could try to compile them at runtime, as we are aware that typescript is installed as peer dependency anyway (cause the user is already using .ts files) or ... I dont know 🤔 I'm not so deep into that right now, I need to build up some knowledge...
|
FFR: |
Co-authored-by: Felipe Barso <aprendendofelipe@users.noreply.github.com>
|
@aprendendofelipe assuming that
Can we find a solution that works, so that the tests are not failing (without touching them obviously) |
extracted from #1206
__dirnameandpg.Client#1206Edit: behavior changed to tryout using process cwd