gh-754: Allow undefined count #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlewhywhat
force-pushed
the
gh-754-optional-count
branch
from
205fd60
to
f2c9545
Compare
|
@Shinigami92 does it make sense to you? |
Yeah, could make sense. |
littlewhywhat
force-pushed
the
gh-754-optional-count
branch
from
fb3f14b
to
047de67
Compare
littlewhywhat
force-pushed
the
gh-754-optional-count
branch
2 times, most recently
from
bef0c45
to
e726740
Compare
littlewhywhat
force-pushed
the
gh-754-optional-count
branch
from
e726740
to
2d3c40a
Compare
|
hi @Shinigami92! Thanks for the tip to use default value 👍 i think it's ready to merge. Would appreciate if you take a look and approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-754
Allow count be
undefined... looks like it was supported before in js version as well as cli doesn't provide it but then count is typed as compulsory.TODO: