Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ws to 7.4.6 [SECURITY] #797

Merged
merged 1 commit into from
May 31, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 28, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.4.4 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in ws@7.4.6 (websockets/ws@00c425e).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

馃搮 Schedule: "" (UTC).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot changed the title Update dependency ws to 7.4.5 [SECURITY] Update dependency ws to 7.4.5 [SECURITY] - autoclosed May 28, 2021
@renovate renovate bot closed this May 28, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch May 28, 2021 23:05
@renovate renovate bot changed the title Update dependency ws to 7.4.5 [SECURITY] - autoclosed Update dependency ws to 7.4.5 [SECURITY] May 29, 2021
@renovate renovate bot reopened this May 29, 2021
@renovate renovate bot restored the renovate/npm-ws-vulnerability branch May 29, 2021 00:29
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from c98ec88 to 03d3e28 Compare May 29, 2021 00:30
@renovate renovate bot changed the title Update dependency ws to 7.4.5 [SECURITY] Update dependency ws to 7.4.6 [SECURITY] May 29, 2021
@Shinigami92 Shinigami92 added the c: dependencies Pull requests that adds/updates a dependency label May 29, 2021
@littlewhywhat littlewhywhat merged commit a5794b4 into master May 31, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch May 31, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants