Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize sort for migration files #818

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

Shinigami92
Copy link
Collaborator

closes #813

Stabilize sort for migration files by using the name of the migration as a second comparator argument

@Shinigami92 Shinigami92 added the old-label enhancement Functionality that enhances existing features label Jul 21, 2021
@Shinigami92 Shinigami92 self-assigned this Jul 21, 2021
Copy link
Contributor

@littlewhywhat littlewhywhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in the ticket unfortunately i don't see at the moment why it's needed. Migrations are supposed to have different timestamps and using names for sorting them is likely just a bad pattern.

@littlewhywhat littlewhywhat merged commit c0082d9 into master Dec 14, 2021
@Shinigami92 Shinigami92 deleted the stable-sort-for-migration-files branch March 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old-label enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use stable sort when ordering files by timestamp
2 participants