Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept ts-node tsconfig overrides #929

Merged
merged 2 commits into from Apr 11, 2024
Merged

Conversation

BriungRi
Copy link
Contributor

The ts-node key in ts-config allows for tsconfig overrides

AFAICT, tsnode.register(tsconfig) doesn't automatically do this override. This manually does the override by using Object.assign.

bin/node-pg-migrate Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Apr 5, 2024
@Shinigami92 Shinigami92 changed the title Accept ts-node overrides feat: accept ts-node tsconfig overrides Apr 11, 2024
Shinigami92
Shinigami92 previously approved these changes Apr 11, 2024
@Shinigami92 Shinigami92 added this to the v7.0 milestone Apr 11, 2024
@Shinigami92
Copy link
Collaborator

I will release this in a v7.0.0-alpha.3 soon, but first I will finish the restructure migration of the src/operations folder.

Ignore the failing coverage for now, this can only be fixed if someone of @salsita allowed Codecov in #1014 (comment)

@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Apr 11, 2024
@Shinigami92 Shinigami92 merged commit de5daa0 into salsita:main Apr 11, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants