Fix deprecation warning - html.escape instead cgi.escape

salsita · Oct 29, 2018 · c579afc · c579afc
1 parent 5fd3187
commit c579afc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,6 +1,6 @@
 # History
 
-## 3.0.8 (2018-10-29)
+## 3.0.9 (2018-10-29)
 * Deprecation warning fix
 
 ## 3.0.7 (2018-10-25)

diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 import os
 import sys
 
-VERSION = '3.0.8'
+VERSION = '3.0.9'
 
 with open('README.md', encoding='utf-8') as readme_file:
     readme = readme_file.read()

diff --git a/shishito/reporting/junithtml.py b/shishito/reporting/junithtml.py
@@ -18,6 +18,8 @@
 from py.xml import html
 from py.xml import raw
 
+from html import escape
+
 
 
 
@@ -309,10 +311,10 @@ def _append_stacktrace_section(log, report):
             else:
                 exception = line.startswith("E   ")
                 if exception:
-                    stacktrace_p.append(html.span(raw(html.escape(line)),
+                    stacktrace_p.append(html.span(raw(escape(line)),
                                                   class_='error'))
                 else:
-                    stacktrace_p.append(raw(html.escape(line)))
+                    stacktrace_p.append(raw(escape(line)))
             stacktrace_p.append(html.br())
         log.append(stacktrace_p)