Add suport for generating reports for non selenium project #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config_path = os.path.join(self.project_root, 'config') | ||
| if not os.path.exists(config_path): | ||
| return None |
There was a problem hiding this comment.
I'd personally put all the code below return None in the else: branch. I know it's not necessary in this case, but I think it could be more readable that way. Just a suggestion though.
| config_path = os.path.join(self.project_root, 'config') | ||
| #return_configs = [] |
This was referenced Jan 22, 2015
sankaritan
pushed a commit
that referenced
this pull request
Jan 22, 2015
Add suport for generating reports for non selenium project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for using shishito_runner in non selenium project: