Create backup script on control nodes, add metadata for backupninja #19
Conversation
opencontrail/meta/backupninja.yml
Outdated
| fs_excludes: | ||
| - /var/backups/cassandra/OPENCONTRAIL_CONTROL_DB/* | ||
| fs_includes: | ||
| - /var/backups/cassandra/OPENCONTRAIL_CONTROL_DB/{{ system.name }}.{{ system.domain }}/ |
There was a problem hiding this comment.
Use grains instead or pillar that comes for these states.
opencontrail/files/cassandra_backup
Outdated
| NODETOOL=$(which nodetool) | ||
|
|
||
| TODAY_DATE=$(date +%F) | ||
| NODENAME=$(salt-call pillar.get linux:network:fqdn --out=newline_values_only) |
There was a problem hiding this comment.
Use grains instead or better just hostname -f and rely on correctly set hostname. Dependency on other formulas is not necessary.
opencontrail/files/cassandra_backup
Outdated
| SNAPSHOT_NAME=snp-$(date +%F-%H%M-%S) | ||
| DATE_SCHEMA=$(date +%F-%H%M-%S) | ||
|
|
||
| DB_BIND_HOST=$(salt-call pillar.get opencontrail:database:bind:host --out=newline_values_only) |
There was a problem hiding this comment.
You are rendering this file as jinja template so you can reference {{ opencontrail.database.bind.host }} directly without need to call salt.
opencontrail/cassandra_backup.sls
Outdated
| @@ -0,0 +1,7 @@ | |||
| /usr/bin/cassandra_backup: | |||
There was a problem hiding this comment.
Use /usr/local/bin instead. It's also better to use dash (I would name it contrail-cassandra-backup) than underscore.
opencontrail/files/cassandra_backup
Outdated
| declare -a KEYSPACE_LIST=( $( ${CQL_SH} -e "DESC KEYSPACES" | awk '{RS="\\s+"; if(NF>0){print}}' | sort ) ) | ||
|
|
||
| # Make sure backup Directory exists | ||
| mkdir -p "${BACKUP_SCHEMA_DIR}" |
There was a problem hiding this comment.
You shouldn't fail if it already exists, use this instead:
[ -d "${BACKUP_SCHEMA_DIR" ] || mkdir -p "${BACKUP_SCHEMA_DIR}"
There was a problem hiding this comment.
mkdir won't fail if -p key is given
There was a problem hiding this comment.
I would rather manage that dirs by backup.sls in opencontrail formula. (rights/content, etc..)
|
Hi Filip, |
| @@ -0,0 +1,58 @@ | |||
| {% from "opencontrail/map.jinja" import database with context %} | |||
There was a problem hiding this comment.
You should strip empty lines by using {%- and -%}
There was a problem hiding this comment.
And this file doesn't need to be a jinja template at all.
| @@ -0,0 +1,7 @@ | |||
| /usr/local/bin/contrail-cassandra-backup: | |||
There was a problem hiding this comment.
I would prefer not introducing new state (cassandra_backup.sls) but having this as a part of opencontrail.control
| NODETOOL=$(which nodetool) | ||
|
|
||
| TODAY_DATE=$(date +%F) | ||
| NODENAME="{{ node_fqdn }}" |
List of related PRs coming later